Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(trg1.01): add more detailed information about importance of the readme file #530

Merged
merged 13 commits into from
Jan 10, 2024

Conversation

FaGru3n
Copy link
Contributor

@FaGru3n FaGru3n commented Dec 6, 2023

Description

fixes eclipse-tractusx/sig-infra#359

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@FaGru3n FaGru3n added the documentation Improvements or additions to documentation label Dec 6, 2023
@FaGru3n FaGru3n self-assigned this Dec 6, 2023
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hzierer hzierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments and proposals inline

docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
docs/release/trg-1/trg-1-1.md Outdated Show resolved Hide resolved
@FaGru3n FaGru3n dismissed SebastianBezold’s stale review December 7, 2023 07:25

updated docs branch

@FaGru3n FaGru3n changed the title docs: add more detailed information about importance of the readme file docs(trg1.01): add more detailed information about importance of the readme file Dec 12, 2023
Copy link
Contributor

@hzierer hzierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hzierer hzierer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FaGru3n FaGru3n merged commit 2712f6c into main Jan 10, 2024
4 checks passed
@FaGru3n FaGru3n deleted the chore/update-trg1-1 branch January 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TRG 1.01: Add more T&T, fix typo
5 participants